Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4808: Fix language detection for first time users #644

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

dkozickis
Copy link
Contributor

GN-4808: Fix language detection for users that are coming to GN for the first time

Overview

There's a chance that matchUserLocaleToSupportedLocale will return undefined value, calling toLowerCase will then throw an error, this might happen when application is loading for the first time for the user, and there's nothing yet stored in the browser for the user.

connected issues and PRs:

Setup

  1. Checkout
  2. ember s --proxy https://reglementairebijlagen.lblod.info

How to test/reproduce

  1. Try to open in incognito tab

Challenges/uncertainties

There's no TS in this project, without it's help I've missed this possibility.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@dkozickis dkozickis merged commit eca34d2 into master Apr 22, 2024
3 checks passed
@dkozickis dkozickis deleted the GN-4808 branch April 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants