GN-4808: Fix language detection for first time users #644
+19
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GN-4808: Fix language detection for users that are coming to GN for the first time
Overview
There's a chance that
matchUserLocaleToSupportedLocale
will return undefined value, callingtoLowerCase
will then throw an error, this might happen when application is loading for the first time for the user, and there's nothing yet stored in the browser for the user.connected issues and PRs:
Setup
ember s --proxy https://reglementairebijlagen.lblod.info
How to test/reproduce
Challenges/uncertainties
There's no TS in this project, without it's help I've missed this possibility.
Checks PR readiness