GN-4800: Bump appuniversum to v3

[dkozickis]

Overview

GN-4800: Bump @appuniversum/ember-appuniversum to 3.4.1

• Bump @appuniversum/ember-appuniversum to 3.4.1

  • Update breaking changes, mainly removing two-way binding from AuTextarea and AuInput components.
  • Change how appuniversum SCSS is imported in the app.
  • Add a key to AuDatePicker localisation.

• Bump @lblod/ember-rdfa-editor-lblod-plugins to 17.0.0

• Bump @lblod/ember-environment-banner to 0.5.0

connected issues and PRs:

• https://binnenland.atlassian.net/browse/GN-4800

Setup

1. Checkout
2. npm i

How to test/reproduce

• Start GN ember s --proxy https://dev.gelinkt-notuleren.lblod.info
• Navigate around the app, make sure everything still works, try to input/change input of input field and textareas that you see, as those were the main changes.

Checks PR readiness

• UI: works on smaller screen sizes
• UI: feedback for any loading/error states
• Check cancel/go-back flows
• Check database state correct when deleting/updating (especially regarding relationships)
• changelog
• npm lint
• no new deprecations

[dkozickis]

Converted to Draft as dependency-lint is failing, will work on it .

P.S. Ready for review again

[piemonkey]

@dkozickis I think dependency lint is just because there's a new peer-dep for AU >3.

I think that there's more to this upgrade though than this, unfortunately the problems will only come up by either testing every template in the app or searching for deprecated uses of components, since we don't have TS and glint to lint our templates.

When doing this in the plugins, I looked at the release notes of AU and checked the usage of the components. For example v2.13.0 includes this deprecation of @value on <AuInput>, which I can see still exists in app/components/zitting/manage-zittingsdata.hbs.

[dkozickis]

For example v2.13.0 includes this deprecation of @value on <AuInput>, which I can see still exists in app/components/zitting/manage-zittingsdata.hbs.

@value is deprecated and removed in v3, instead value (no @) is used, with change handler.

[piemonkey]

@dkozickis Ah, sorry, when I looked at the PR it was just the dependency change, none of the code changes, I guess I caught it when not all the commits were in.

[piemonkey]

LGTM, just one comment. Happy for it to be merged after that or if there's a good reason not to do it.

[piemonkey]

Personally I think we can go for ^3.4.1 as AU versions follow semver pretty well.

[piemonkey]

Is there a reason to override this rather than upgrading? I tested this PR with ^3.1.0 and it seems to work.

[dkozickis]

I've preferred to override to 2.3.7 because all other dependencies have it, below is the output of ember dependency-lint, I will crate tech tasks to update ember-concurrency everywhere else 🤔

ember-concurrency
Allowed: (any single version)
Found: 3.1.1, 2.3.7
frontend-gelinkt-notuleren
├── [email protected]
├─┬ @appuniversum/ember-appuniversum
│ └── [email protected]
├─┬ @lblod/ember-mock-login
│ └── [email protected]
├─┬ @lblod/ember-rdfa-editor-lblod-plugins
│ └── [email protected]
└─┬ ember-power-select
  └── [email protected]