GN-4827: Remove RDFA Tools from RDFA Editor #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeforgit
requested changes
May 13, 2024
| @@ -104,19 +104,6 @@ | |||
| {{yield to='sidebar'}} | |||
| {{#if @shouldEditRdfa}} | |||
There was a problem hiding this comment.
My bad on not clarifying the ticket, but I already put in a mechanism to hide the rdfa editing tools, this boolean. It should really just be a matter of setting that boolean to false in templates/regulatory-statements/edit.hbs
however, see other comment
There was a problem hiding this comment.
I should have been smarter. Saw that boolean, decided to raise it all with napalm instead. Changed now.
| @@ -104,19 +104,6 @@ | |||
| {{yield to='sidebar'}} | |||
| {{#if @shouldEditRdfa}} | |||
| <Plugins::Link::LinkEditor @controller={{this.controller}} /> | |||
There was a problem hiding this comment.
I don't really know how this got in here, but since we're pretty settled on the popout link editor, we can remove this sidebar version here
abeforgit
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
GN-4827: Remove RDFA Tools from RDFA Editor
Do not render
RdfaEditorAttributeEditorDebugInfoThey are not meant for GN users
connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4827
Setup
How to test/reproduce
ember s --proxy https://dev.gelinkt-notuleren.lblod.infoChecks PR readiness