Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4692: Enable BesluitTopicPlugin #662

Merged
merged 2 commits into from
May 20, 2024
Merged

GN-4692: Enable BesluitTopicPlugin #662

merged 2 commits into from
May 20, 2024

Conversation

dkozickis
Copy link
Contributor

@dkozickis dkozickis commented May 20, 2024

Overview

Enabble BesluitTopicPlugin plugin allowing to connect multiple topics (BesluitThema) to a decision (besluit).

connected issues and PRs:

Setup

  1. Checkout
  2. Run

How to test/reproduce

Please repeat after me, see the video :)

CleanShot.2024-05-20.at.23.04.55.mp4

Challenges/uncertainties

  1. UI pill is kinda meh 🤷🏻‍♂️

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@dkozickis dkozickis enabled auto-merge May 20, 2024 20:26
@dkozickis dkozickis merged commit 58b22db into master May 20, 2024
3 checks passed
@dkozickis dkozickis deleted the GN-4692 branch May 20, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant