Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuToggleSwitch must include the label as a block #663

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented May 22, 2024

Overview

The API of the AuToggleSwitch changed with the new version, so it broke

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4834

How to test/reproduce

Go to the document publication screen, you should see a label in all the switches

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde self-assigned this May 22, 2024
@lagartoverde lagartoverde merged commit b8815b9 into master May 22, 2024
3 checks passed
@lagartoverde lagartoverde deleted the GN-4834 branch May 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants