Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unsaved-changes dialog does not show up when saving intro/outro of a meeting #675

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

elpoelma
Copy link
Contributor

Overview

This PR ensures that the unsaved-changes dialog does not show up when selecting the save and exit button while editing the intro/outro of a meeting.

connected issues and PRs:

None

How to test/reproduce

  • Start the application
  • Open a meeting and edit the intro or outro
  • Select the save and exit button
  • Ensure that the unsaved-changes dialog no longer shows up

Challenges/uncertainties

This PR includes some changes in the logic of the intro and outro pages. It ensures that the dirty property is equal to false after having saved the document by clearing the editor property. The editor property then gets reinstated when a new editor instance is created just after saving.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Jun 11, 2024
@elpoelma elpoelma self-assigned this Jun 11, 2024
@elpoelma elpoelma force-pushed the fix/meeting-text-save-dialog branch from ad6ded9 to 5f0f9eb Compare June 11, 2024 11:20
@elpoelma elpoelma merged commit 3df4fe7 into master Jun 11, 2024
3 checks passed
@elpoelma elpoelma deleted the fix/meeting-text-save-dialog branch June 11, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant