Fix link URL input selection #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced here: #448 In order to tweak the styling of embedded regulatory statements in agenda points. Since it no longer seems possible to select these PM nodes, this styling never actually gets applied to these. The background color was however being applied to any selection, not just those in embedded regulatory statements, so was causing the input for the url of a link to have an invisible selection.
lagartoverde
approved these changes
Jun 13, 2024
lagartoverde
approved these changes
Jun 13, 2024
elpoelma
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove selection styling hacks that seem not relevant and broke links. This was introduced here: #448 In order to tweak the styling of embedded regulatory statements in agenda points. Since it no longer seems possible to select these PM nodes, this styling never actually gets applied to these. The background color was however being applied to any selection, not just those in embedded regulatory statements, so was causing the input for the url of a link to have an invisible selection.
connected issues and PRs:
N/A
Setup
N/A
How to test/reproduce
Insert a link, add a URL, then select part of the URL to see that it is highlighted. It's also worth checking that embedded regulatory statements behave as before.
Challenges/uncertainties
N/A
Checks PR readiness