Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed document service not targeting the correct predicates #681

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Jun 18, 2024

Overview

With the change of the editor, we stopped using relative uris like a and started using 'http://www.w3.org/1999/02/22-rdf-syntax-ns#type' instead. We already make this fix on the plugins repo but failed to do here. We might need to do it somewhere else but don't know where so if someone knows another place is targeting relative uris let me know.

connected issues and PRs:

GN-4864

Setup

None

How to test/reproduce

Create an agendapoint, write a description on it, then go to a meeting and try to add the agendapoint and copy its description. It should be copied correctly while previously it was not

Challenges/uncertainties

As I said we could be missing the same fix on other places

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde self-assigned this Jun 18, 2024
@lagartoverde lagartoverde added the bug Something isn't working label Jun 18, 2024
Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm a bit surprised that the triple-extractor does not expand a to http://www.w3.org/1999/02/22-rdf-syntax-ns#type automatically.

@lagartoverde lagartoverde merged commit 5f5953d into master Jun 20, 2024
3 checks passed
@lagartoverde lagartoverde deleted the GN-4864 branch June 20, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants