Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4829: Meeting design updates #685

Merged
merged 5 commits into from
Jul 9, 2024
Merged

GN-4829: Meeting design updates #685

merged 5 commits into from
Jul 9, 2024

Conversation

dkozickis
Copy link
Contributor

@dkozickis dkozickis commented Jun 27, 2024

Overview

GN-4829: Design updates to meetings

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4829

Setup

  1. Checkout

Before/after

Before After
CleanShot 2024-06-27 at 15 18 07@2x CleanShot 2024-06-27 at 15 42 02@2x

How to test/reproduce

See if functionality still works 🙏🏻

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@dkozickis dkozickis force-pushed the GN-4829 branch 2 times, most recently from dd08eac to 2cd6330 Compare June 27, 2024 12:45
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"undefined" showing up next to dates, this is on a new meeting. I don't see this on your screenshots, so maybe it's my setup?

image

This warning box is now weirdly sized
image

this is how it used to look:
image

spacing here:

image

When the window is not at max width, this warning pill breaks to a newline too soon (still plenty of space left)
also, left margin isn't aligned (was specifically mentioned in the design doc)
image

@dkozickis
Copy link
Contributor Author

Thank you @abeforgit, I haven't properly rechecked with all of the pills in view. Will fix 🙇🏻

@abeforgit abeforgit enabled auto-merge July 9, 2024 14:15
@abeforgit abeforgit merged commit 6d4e4b6 into master Jul 9, 2024
2 of 3 checks passed
@abeforgit abeforgit deleted the GN-4829 branch July 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants