Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4958: add snippet node and nodeview to regulatory-statement editor config #691

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jul 22, 2024

Overview

This PR ensures that the snippet node-spec and nodeview are correctly added to the regulatory-statement editor configuration.

connected issues and PRs:

GN-4958

How to test/reproduce

  • Open the application
  • Create a regulatory statement based on a template which contains snippet placeholders
  • You should be able to use the snippet placeholder to insert a snippet without issues

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Jul 22, 2024
@elpoelma elpoelma requested a review from lagartoverde July 22, 2024 08:28
@elpoelma elpoelma self-assigned this Jul 22, 2024
@elpoelma elpoelma merged commit ec65870 into master Jul 22, 2024
3 checks passed
@elpoelma elpoelma deleted the fix/enable-regulatory-statement-snippets branch July 22, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants