Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4953: fix issue with meeting absentees not shown #692

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jul 22, 2024

Overview

This PR fixes an issue in the participation-list component which displays the attendance of the different mandatees in a meeting. It corrects the approach in how absentees are fetched/retrieved.

connected issues and PRs:

GN-4953

How to test/reproduce

  • Open the app
  • Open a meeting
  • Modify the attendance of a meeting (and add some absentees)
  • The absentees should show up correctly

Challenges/uncertainties

When relationships of a model are correctly loaded in the ember-data store, you can not retrieve these using javascript '.' getters. You can either use the .get('...') or .belongsTo('...') methods.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Jul 22, 2024
@elpoelma elpoelma requested a review from lagartoverde July 22, 2024 09:20
@elpoelma elpoelma self-assigned this Jul 22, 2024
@elpoelma elpoelma merged commit f67e4c6 into master Jul 22, 2024
3 checks passed
@elpoelma elpoelma deleted the fix/absentees-not-shown branch July 22, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants