Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GN-4962: remove seperate edit button for agenda items #696

Merged
merged 1 commit into from
Aug 13, 2024
Merged

GN-4962: remove seperate edit button for agenda items #696

merged 1 commit into from
Aug 13, 2024
+14 −13

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Aug 9, 2024 •
edited
Loading

Overview

This PR adjusts the meeting design/UX in two ways:

  • Removal of the edit button next to agenda items
  • Make the title of agenda items clickable
connected issues and PRs:

GN-4962

How to test/reproduce

  • Start the app
  • Open a meeting
  • Notice that the edit button next to agenda items is gone
  • If you click on the title of an agenda item, it should open the edit modal.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the enhancement New feature or request label Aug 9, 2024
@elpoelma elpoelma merged commit 6885089 into master Aug 13, 2024
3 checks passed
@elpoelma elpoelma deleted the feat/meeting-design-adaptations branch August 13, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagartoverde lagartoverde lagartoverde approved these changes

@piemonkey piemonkey Awaiting requested review from piemonkey

@abeforgit abeforgit Awaiting requested review from abeforgit

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpoelma @lagartoverde