Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add person variable #703

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Add person variable #703

merged 2 commits into from
Aug 22, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Aug 21, 2024

Overview

Implement the person variable in GN

connected issues and PRs:

GN-4978 and GN-4876

Setup

If testing with local backend, you must make sure you have the vendor proxy service correctly configured

How to test/reproduce

Go to Agendapoints and click on "Insert mandatee from LMB service", and after checking that that works insert a RS template with a person variable

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde added the enhancement New feature or request label Aug 21, 2024
@lagartoverde lagartoverde self-assigned this Aug 21, 2024
@lagartoverde lagartoverde enabled auto-merge August 22, 2024 15:03
@lagartoverde lagartoverde merged commit 31d620b into master Aug 22, 2024
3 checks passed
@lagartoverde lagartoverde deleted the feature/add-person-variable branch August 22, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants