Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date-picker: drop keyboardInstruction setting #705

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Aug 22, 2024

Overview

Since version 1.4.0, duet-date-picker uses basic tables to represent the dropdown calendar. Since screen readers already know how to navigate html tables, the custom keyboardInstruction approach/message is now redundant. See duetds/date-picker#87 for more info.

How to test/reproduce

  • Open the app
  • Open a page where the date picker is used
  • Notice that the calendar used by the date picker is implemented using a basic table

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma force-pushed the fix/drop-date-picker-keyboard-instruction branch from d9c4f70 to c31bdea Compare August 22, 2024 12:44
@elpoelma elpoelma merged commit 156f3db into master Aug 22, 2024
3 checks passed
@elpoelma elpoelma deleted the fix/drop-date-picker-keyboard-instruction branch August 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants