Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5000: adjust rdfa-annotation stylesheets to also include full URIs #707

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Aug 23, 2024

Overview

This PR adjusts the stylesheets of rdfa-annotations to also include full URIs.
Unsure if all these style rules are still needed.
Among others, this fixes the short description of decisions not being marked as public.

Not really proud of this PR 😢

connected issues and PRs:

GN-5000

How to test/reproduce

  • Start the application
  • Open a meeting with agendapoints which contain decisions with descriptions
  • Open the publish page with the 'notulen'/'document' tab
  • Ensure that the 'short description' parts of the decisions are being marked as public.

Challenges/uncertainties

As mentioned before, I am unsure if all these css rules are still necessary/used. We should probably prune them one day.
This solution is not ideal, but is what is needed right now to fix prod.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Aug 23, 2024
@elpoelma elpoelma self-assigned this Aug 23, 2024
@elpoelma elpoelma changed the title adjust rdfa-annotation stylesheets to also include full URIs GN-5000: adjust rdfa-annotation stylesheets to also include full URIs Aug 23, 2024
@elpoelma elpoelma force-pushed the fix/rdfa-annotations branch from 36fa11a to dcab7f3 Compare August 23, 2024 14:37
Base automatically changed from fix/annotation-styling to v5.19.x August 23, 2024 14:47
@abeforgit abeforgit merged commit 555f8be into v5.19.x Aug 23, 2024
3 checks passed
@abeforgit abeforgit deleted the fix/rdfa-annotations branch August 23, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants