Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4937: add support for snippet previews #708

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Aug 25, 2024

Overview

This (draft) PR updates the editor-plugins to the dev commit found on lblod/ember-rdfa-editor-lblod-plugins#468. It implements collapsible snippet previews.

connected issues and PRs:

GN-4937
lblod/ember-rdfa-editor-lblod-plugins#468

How to test/reproduce

  • Start the application
  • Create a regulatory statement based on a template containing a snippet placeholder
  • Open the 'Insert snippet' modal, and notice that you can preview each of the snippets listed

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma self-assigned this Aug 25, 2024
@elpoelma elpoelma force-pushed the GN-4937-snippet-previews branch from cb36b11 to 748e357 Compare August 27, 2024 14:55
@elpoelma elpoelma force-pushed the GN-4937-snippet-previews branch from 748e357 to 8561e27 Compare August 27, 2024 14:56
@elpoelma elpoelma marked this pull request as ready for review August 29, 2024 08:54
@elpoelma elpoelma merged commit 85967f8 into master Aug 29, 2024
3 checks passed
@elpoelma elpoelma deleted the GN-4937-snippet-previews branch August 29, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant