Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload the correct templates upon IV creation #714

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Preload the correct templates upon IV creation #714

merged 5 commits into from
Oct 8, 2024

Conversation

abeforgit
Copy link
Member

@abeforgit abeforgit commented Sep 9, 2024 •
edited
Loading

Overview

draft because it's a bit too ducktapey

connected issues and PRs:

Setup

How to test/reproduce

Challenges/uncertainties

TODO: need to figure out which URI is the most stable for a certain template

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@abeforgit abeforgit force-pushed the fix/polymorphic-notulen branch 2 times, most recently from e47d3d9 to c6b943c Compare September 28, 2024 21:44
@abeforgit abeforgit force-pushed the feat/preload-IV-agenda-items branch from 674cbbb to 7a0a182 Compare September 28, 2024 21:49
@abeforgit abeforgit force-pushed the fix/polymorphic-notulen branch from c6b943c to c851cc2 Compare September 28, 2024 21:51
@abeforgit abeforgit changed the base branch from fix/polymorphic-notulen to GN-4985-lmb-queries September 28, 2024 21:52
@abeforgit abeforgit force-pushed the feat/preload-IV-agenda-items branch from 7a0a182 to dc7d16b Compare September 28, 2024 21:52
@elpoelma elpoelma force-pushed the feat/preload-IV-agenda-items branch from 221e6f8 to 0747893 Compare October 8, 2024 12:31
Base automatically changed from GN-4985-lmb-queries to master October 8, 2024 12:33
@elpoelma elpoelma force-pushed the feat/preload-IV-agenda-items branch from 0747893 to a4ba3e4 Compare October 8, 2024 12:37
@elpoelma elpoelma marked this pull request as ready for review October 8, 2024 12:38
@elpoelma elpoelma merged commit f5c107b into master Oct 8, 2024
3 checks passed
@elpoelma elpoelma deleted the feat/preload-IV-agenda-items branch October 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeforgit @elpoelma