Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/autofill variable #715

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Feat/autofill variable #715

merged 8 commits into from
Oct 7, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Sep 9, 2024

Overview

Implement lblod/ember-rdfa-editor-lblod-plugins#472

connected issues and PRs:

GN-4901

How to test/reproduce

You can create a Besluit or RS with a template that contains an autofilled variable, if you are proxing to dev, you can search for autofilled as I have already created templates for testing

Challenges/uncertainties

We have to discuss yet the configuration, this is just for purely testing the behaviour

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde marked this pull request as ready for review October 7, 2024 14:15
@lagartoverde lagartoverde merged commit a70ee5f into master Oct 7, 2024
3 checks passed
@lagartoverde lagartoverde deleted the feat/autofill-variable branch October 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant