Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/download meeting part #722

Merged
merged 19 commits into from
Oct 8, 2024
Merged

Feat/download meeting part #722

merged 19 commits into from
Oct 8, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Oct 2, 2024

Overview

Added a way of downloading different parts of the meeting as HTML
https://www.figma.com/design/UVPMVe7O29nt7G1rRJ6uH9/installatievergadering?node-id=351-337&t=M0DRZAdacQNR1WNw-4

connected issues and PRs:

GN-4902

Setup

None

How to test/reproduce

Go to a meeting, click on the acties menu, and then on the "Onderdelen kopiëren en downloaden" you should be able to download all the meeting parts there

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

app/components/download-meeting-part.gjs Outdated Show resolved Hide resolved
app/components/download-meeting-part.gjs Outdated Show resolved Hide resolved
translations/en-us.yaml Outdated Show resolved Hide resolved
translations/en-us.yaml Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
translations/en-us.yaml Outdated Show resolved Hide resolved
translations/nl-BE.yaml Outdated Show resolved Hide resolved
translations/nl-BE.yaml Outdated Show resolved Hide resolved
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 more things:

  • I've merged @piemonkey 's work on the ability to delete template comments from the published html. You should use this for the decision export, for all the others the prepublisher already handles this
  • again for decisions only: somewhere in the publication pipeline we replace the decision URI from "http://example.net/new-decision" with a real, new decision URI. We should do this logic for the decision download as well.
  • and also for decisions: we should wrap it in a div that defines the prefixes we use. again, for all the other things this is something we already do somewhere else in the app

Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another thing: the agenda items are not in order on the export screen

@lagartoverde
Copy link
Contributor Author

Hey @abeforgit , I write here because rocket chat seems to be broken, the agendapoints are sorted by position, are finding a bug with this?
And I also saw the "http://example.net/new-decision" where does that come from? because if I create a new agendapoint the besluit uri gets generated, and if I publish the one with the new-decision URI it doesn't get replaced, so I must be missing something

@lagartoverde lagartoverde requested a review from abeforgit October 7, 2024 14:10
@abeforgit abeforgit merged commit dbb8187 into master Oct 8, 2024
3 checks passed
@abeforgit abeforgit deleted the feat/download-meeting-part branch October 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants