Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always open insert menu and move insert snippet button to the bottom #726

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Oct 8, 2024

Overview

Always open insert menu and move insert snippet button to the bottom of the list

connected issues and PRs:

GN-5092

Setup

None

How to test/reproduce

Go to agendapoints edit and RB edit and check that the insert menu is open by default and the insert snippet button is at the bottom

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde self-assigned this Oct 8, 2024
@abeforgit abeforgit enabled auto-merge October 8, 2024 07:54
@abeforgit abeforgit merged commit efe418d into master Oct 8, 2024
3 checks passed
@abeforgit abeforgit deleted the feat/always-open-insert-menu branch October 8, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants