Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus mode to the meeting form #735

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Add focus mode to the meeting form #735

merged 5 commits into from
Oct 20, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Oct 18, 2024

Overview

Add focus besluit mode to the meeting form

connected issues and PRs:

GN-5091

Setup

None

How to test/reproduce

Go to a meeting, you will have a switch on top, verify that when you activate the switch it correcly hides everything except the steps 1 3 and 5, also the publish and the copy buttons should be switched

Challenges/uncertainties

If we expect more custom modes to be added we could create a variable to show and hide each block and with the focus mode hide the sections we want, I didn't do it because I think there are no plans on the horizon for this, but I could be wrong.
Also awaiting for confirmation on the text of the tooltip

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde self-assigned this Oct 18, 2024
@lagartoverde lagartoverde added the enhancement New feature or request label Oct 18, 2024
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the toggle state doesn't persist...

@abeforgit abeforgit merged commit 2840bb9 into master Oct 20, 2024
3 checks passed
@abeforgit abeforgit deleted the feat/focus-mode branch October 20, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants