Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rdfaAware setting on heading nodes #748

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Oct 29, 2024

Overview

This PR disables the rdfaAware setting on heading nodes for two main reasons:

  • To ensure consistency with https://github.com/lblod/frontend-reglementaire-bijlage
  • The rdfaAware setting never really worked very well in combination with heading nodes. Typically (IMO) it's not a good idea to mix markup/styled nodes (e.g. headings, paragraphs) with data nodes (block_rdfa, inline_rdfa...)
connected issues and PRs:

lblod/frontend-reglementaire-bijlage#291

How to test/reproduce

  • Start the frontend
  • Open any agendapoint/regulatory statement/intro,outro
  • Notice that the heading nodes are no longer rdfa-aware: you can easily enter inside of them for example, no border around them...
  • Check if the copy function still works as expected

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma self-assigned this Oct 29, 2024
@elpoelma elpoelma marked this pull request as draft October 29, 2024 10:55
@elpoelma elpoelma marked this pull request as ready for review October 29, 2024 11:03
@abeforgit abeforgit merged commit 0063215 into master Oct 29, 2024
3 checks passed
@abeforgit abeforgit deleted the heading-rdfa-awareness branch October 29, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants