Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5233: mandataris-rank - take diaeresis into account #770

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 14, 2024

Overview

This PR ensures that letters with a diaeresis are taken into account when converting mandatee ranks to numbers.

connected issues and PRs:

GN-5233

How to test/reproduce

  • Open the frontend
  • Create/open an IV
  • Ensure the 'IVGR4-LMB-1-rangorde-gemeenteraadsleden' is configured somewhere; and the source data (gemeenteraad) should contain at least 24 mandatees
  • Sync the meeting
  • Ensure the mandatees are correctly ordered based on rank (including 'TWEEËNTWINTIGSTE' and 'DRIEËNTWINTIGSTE')

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Nov 14, 2024
@abeforgit abeforgit merged commit 2245da8 into master Nov 14, 2024
3 checks passed
@abeforgit abeforgit deleted the fix/mandataris-rangorde-convertor branch November 14, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants