Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5309: add support for fusie IVs #785

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Dec 3, 2024

Overview

This PR includes support for 'fusiegemeenten' to set up their inauguration meeting.
Specifically, the following changes are included:

  • A slight rework of the installatievergadering api for readability. Includes a custom Map implementation with support for default values and batch-setting map entries
  • The addition of the fusietemplates to the IV configuration
connected issues and PRs:

GN-5309

Setup

Ensure that you're connected to QA/PROD RB

How to test/reproduce

  • Start the app
  • Login as a 'fusiegemeente' gemeente/OCMW
  • Ensure you can create both a 'gemeente' and 'OCMW' inauguration meeting
  • You should still be able to create meetings in other municipalities
  • Both 'Lokeren' and 'Antwerpen' should have no 'Politieraad' AP

Challenges/uncertainties

I reworked the installatievergadering API to what I think is a bit more readable/less dense. Let me know if you'd prefer the old version.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the enhancement New feature or request label Dec 3, 2024
@elpoelma elpoelma self-assigned this Dec 3, 2024
@abeforgit abeforgit enabled auto-merge December 3, 2024 15:15
@abeforgit abeforgit merged commit b8c9793 into master Dec 3, 2024
2 of 3 checks passed
@abeforgit abeforgit deleted the GN-5309-fusie-templates branch December 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants