Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration per administrative unit #787

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

lagartoverde
Copy link
Contributor

Overview

Add a way of adding configuration per administrative unit, in the future this will be replaced by user preferences and a call to the backend.
Also added the config needed to test lblod/ember-rdfa-editor-lblod-plugins#515

connected issues and PRs:

GN-5235
lblod/ember-rdfa-editor-lblod-plugins#515

Setup

None

How to test/reproduce

Login as Gemeente Gent, notice the style of the article titles is the old one. Then login as any other admin unit and notice we have the new article titles in there

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde added the enhancement New feature or request label Dec 4, 2024
@lagartoverde lagartoverde self-assigned this Dec 4, 2024
Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

  • There's a high chance OCMW Gent want this change as well, so we probably also want to add a config for them
  • I know we do it in quite a few places, but I'm more of a fan to use URI's to identify resources instead of their IDs. URIs should be the same on every environment, but IDs could (technically) differ
  • In the future we will probably want to move these configuration settings to a seperate ember-service (as more options will come and users will be able to edit them). Not needed now though.

@lagartoverde lagartoverde requested a review from elpoelma December 5, 2024 14:29
@lagartoverde lagartoverde merged commit 3ad947f into master Dec 9, 2024
3 checks passed
@lagartoverde lagartoverde deleted the feat/config-per-admin-unit branch December 9, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants