Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the date time picker to use the au time picker #788

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

lagartoverde
Copy link
Contributor

Overview

Use the au time picker instead of manual implementation of the same behaviour.

connected issues and PRs:

Solves GN-5280

Setup

None

How to test/reproduce

Create a new meeting and check the time picker works as expected

Challenges/uncertainties

The UI changes a little bit

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde added the bug Something isn't working label Dec 4, 2024
@lagartoverde lagartoverde self-assigned this Dec 4, 2024
@lagartoverde lagartoverde merged commit f760dcf into master Dec 5, 2024
3 checks passed
@lagartoverde lagartoverde deleted the feat/use-au-time-picker branch December 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants