Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5323: include 'toegevoegde schepen' in IVGR8 mandatee table #791

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Dec 6, 2024

Overview

This PR ensures that we include people with the 'Toegevoegde schepen' mandate in the 'Verkozen schepenen' table of IVGR8 (IVGR8-LMB-1-verkozen-schepenen)

connected issues and PRs:

GN-5323

How to test/reproduce

  • Start the frontend
  • Login as a municipality which contains a 'Toegevoegde schepen' in LMB
  • Create/open an IV
  • Sync the meeting
  • In AP7: the 'toegevoegde schepen' should not be included in the tables (they are not known yet by that time)
  • In AP8: the 'toegevoegde schepen' should be included in the table

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Dec 6, 2024
@elpoelma elpoelma self-assigned this Dec 6, 2024
@abeforgit abeforgit enabled auto-merge December 6, 2024 15:03
@abeforgit abeforgit merged commit 8387880 into master Dec 6, 2024
3 checks passed
@abeforgit abeforgit deleted the GN-5323-toegevoegde-schepen branch December 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants