GN-5245: apply new template instantiate method on built-in standard templates #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
elpoelma
force-pushed
the
GN-5245-modernize-templates
branch
from
e0ebd35 to
c46adbc
Compare
lagartoverde
approved these changes
Dec 10, 2024
|
Doesn't lblod/app-gelinkt-notuleren#223 make the |
True, but I left it in case we e.g. accidentally deploy that frontend without running the migrations. I can also remove it of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR ensures that we also apply the new
instantiateUuidsmethod when instantiating the built-in standard templates.This PR should be backwards compatible and should thus also work with current versions of the backend.
connected issues and PRs:
GN-5245
To be tested in conjunction with lblod/app-gelinkt-notuleren#223
Setup
Check-out lblod/app-gelinkt-notuleren#223
How to test/reproduce
See lblod/app-gelinkt-notuleren#223 for instructions on how to test