Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where the normal meeting was not filling the whole page #795

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

lagartoverde
Copy link
Contributor

Overview

Fix regression only occurring on normal meetings where the meeting did not fill the whole horizontal space available

connected issues and PRs:

None

Setup

None

How to test/reproduce

Go to a normal meeting and notice it displays correctly

Challenges/uncertainties

This was introduced here 3a90ef5 it has special cases for certain screen sizes, but I don't think is needed anymore so I didn't added them

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@abeforgit abeforgit merged commit 79d4d92 into master Dec 18, 2024
3 checks passed
@abeforgit abeforgit deleted the bugifx/normal-meetings-not-filling-the-page branch December 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants