Update to ember 5.12

.changeset/clever-ways-look.md

@@ -0,0 +1,5 @@
+---
+'frontend-gelinkt-notuleren': minor
+---
+
+Update to Ember 5.8

.changeset/kind-mangos-confess.md

@@ -0,0 +1,5 @@
+---
+'frontend-gelinkt-notuleren': minor
+---
+
+Upgrade to Ember 5.12

.eslintrc.js

@@ -28,6 +28,17 @@ module.exports = {
     'getter-return': ['error', { allowImplicit: true }],
   },
   overrides: [
+    {
+      files: ['**/*.gjs'],
+      parser: 'ember-eslint-parser',
+      plugins: ['ember'],
+      extends: [
+        'eslint:recommended',
+        'plugin:ember/recommended',
+        'plugin:ember/recommended-gts',
+        'plugin:prettier/recommended',
+      ],
+    },
     // node files
     {
       files: [

.template-lintrc.js

@@ -10,5 +10,9 @@ module.exports = {
       allow: ['unique-id'],
     },
     'no-bare-strings': true,
+    // FIXME We should migrate away from using did-insert and did-update
+    'no-at-ember-render-modifiers': false,
+    // FIXME We only use Input in table-menu, we should refactor to use <input>
+    'no-builtin-form-components': false,
   },
 };

app/components/agenda-manager/agenda-table/body.hbs

@@ -1,5 +1,5 @@
 <SortableObjects
-  @tagName={{'tbody'}}
+  @tagName='tbody'
   @sortEndAction={{@onSort}}
   @sortableObjectList={{@items}}
   @enableSort={{true}}

app/components/decision-copy-parts.gjs

@@ -176,7 +176,7 @@ export default class DecisionCopyParts extends Component {
                       {{part.translatedLabel}}
                     </div>
                     <div class='gn-meeting-copy--structure-content'>
-                      {{(htmlSafer part.content)}}
+                      {{htmlSafer part.content}}
                     </div>
                   </div>
                   <div class='gn-meeting-copy--section-button'>
@@ -189,7 +189,7 @@ export default class DecisionCopyParts extends Component {
               </div>
             {{else}}
               <div class='gn-meeting-copy--structure-content'>
-                {{(htmlSafer section.content)}}
+                {{htmlSafer section.content}}
               </div>
             {{/each}}
           </div>

app/components/document-attachments.hbs

@@ -2,8 +2,8 @@
   <AuFileUpload
     @title={{t 'attachments.attach'}}
     @helpTextDragDrop={{t 'attachments.drag'}}
-    @modelName={{'file'}}
-    @endPoint={{'/files'}}
+    @modelName='file'
+    @endPoint='/files'
     @onFinishUpload={{perform this.uploadedAttachement}}
     @maxFileSizeMB='1024'
     @multiple={{true}}

app/controllers/inbox/meetings/new-inauguration.js

@@ -43,6 +43,7 @@ export default class InboxMeetingsNewInaugurationController extends Controller {
     // TODO use the router service once the bug is fixed:
     //this.router.replaceWith('inbox.meetings');
     // still relevant as of 15/10/2024
+    // eslint-disable-next-line ember/no-deprecated-router-transition-methods
     this.replaceRoute('inbox.meetings');
   };
 }

app/controllers/inbox/meetings/new.js

@@ -67,6 +67,7 @@ export default class InboxMeetingsNewController extends Controller {
     // TODO use the router service once the bug is fixed:
     //this.router.replaceWith('inbox.meetings');
     // still relevant as of 15/10/2024
+    // eslint-disable-next-line ember/no-deprecated-router-transition-methods
     this.replaceRoute('inbox.meetings');
   }
 }

app/controllers/regulatory-statements/edit.js

@@ -300,7 +300,7 @@ export default class RegulatoryStatementsRoute extends Controller {
       },
       autofilledVariable: {
         autofilledValues: {
-          administrativeUnit: `${this.currentSession.classificatie.label} ${this.currentSession.group.naam}`,
+          administrativeUnit: `${this.currentSession.classificatie?.label} ${this.currentSession.group?.naam}`,
         },
       },
     };

app/routes/inbox/regulatory-statements.js

@@ -5,6 +5,7 @@ import { service } from '@ember/service';
 export default class InboxRegulatoryStatementsRoute extends Route {
   @service store;
   @service features;
+  @service router;
 
   queryParams = {
     pageSize: { refreshModel: true },
@@ -15,7 +16,7 @@ export default class InboxRegulatoryStatementsRoute extends Route {
 
   beforeModel(/*transition*/) {
     if (!this.features.isEnabled('regulatoryStatements')) {
-      this.replaceWith('inbox.agendapoints');
+      this.router.replaceWith('inbox.agendapoints');
     }
   }
 

app/routes/regulatory-statements.js

@@ -4,11 +4,12 @@ import { service } from '@ember/service';
 export default class RegulatoryStatementsRoute extends Route {
   @service session;
   @service features;
+  @service router;
 
   beforeModel(transition) {
     this.session.requireAuthentication(transition, 'login');
     if (!this.features.isEnabled('regulatoryStatements')) {
-      this.replaceWith('agendapoints');
+      this.router.replaceWith('inbox.agendapoints');
     }
   }
 }

app/templates/meetings/download/index.hbs

@@ -155,9 +155,10 @@
               /></td>
             <td><AuLink
                 @route='meetings.download.copy'
-                @models={{(array
-                  this.zitting agendapoint.behandeling.documentContainer.id
-                )}}
+                @models={{array
+                  this.zitting
+                  agendapoint.behandeling.documentContainer.id
+                }}
               >
                 {{t 'download.table.copy-options'}}
               </AuLink></td>

config/ember-intl.js

@@ -1,5 +1,3 @@
-/*jshint node:true*/
-
 module.exports = function (/* environment */) {
   return {
     /**

config/release.js

@@ -1,4 +1,3 @@
-/* jshint node:true */
 // var RSVP = require('rsvp');
 
 // For details on each option run `ember help release`