Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to builtin ember types #812

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jan 20, 2025

Overview

This PR includes improved types for:

This change should provides us with:

  • Improved auto-imports
  • Some type information/hinting
  • A path to gradually move to TS
connected issues and PRs:

None

How to test/reproduce

N/A

Challenges/uncertainties

While the ember-data types are still experimental, they are a lot better/correct than the DefinitelyTyped packages.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@piemonkey piemonkey force-pushed the internal/ember-5-deprecations branch from 6feed12 to 33e85d8 Compare January 20, 2025 17:14
Base automatically changed from internal/ember-5-deprecations to master January 20, 2025 17:17
@abeforgit abeforgit enabled auto-merge January 22, 2025 21:27
@abeforgit abeforgit merged commit 601df28 into master Jan 22, 2025
3 checks passed
@abeforgit abeforgit deleted the internal/move-to-builtin-ember-types branch January 22, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants