Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes improved types for:
ember.js
(use built-in types), more info at https://blog.emberjs.com/stable-typescript-types-in-ember-5-1/ember-data
/warpdrive
(use experimental, but more correct types), more info at https://github.com/emberjs/data/blob/main/guides/typescript/index.mdThis change should provides us with:
connected issues and PRs:
None
How to test/reproduce
N/A
Challenges/uncertainties
While the
ember-data
types are still experimental, they are a lot better/correct than the DefinitelyTyped packages.Checks PR readiness