Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-drag-drop dependency #820

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jan 27, 2025

Overview

This PR includes the following changes:

  • Replace ember-drag-drop by ember-sortable
  • Some slight adjustments to the styling of the meeting agenda table
  • Set the deprecated EXTEND_PROTOTYPES flag to false

How to test/reproduce

  • Start the app
  • Ensure the meeting agenda table works as you'd expect + the changes are correctly persisted
  • There should be no issues caused by disabling the EXTEND_PROTOTYPES flag

Challenges/uncertainties

I made some slight css changes to the meeting agenda table, so it might behave slightly different. This is to make the behaviour consistent with the behaviour on RB, and to better align the styles with how ember-sortable behaves.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma requested review from piemonkey, abeforgit and lagartoverde and removed request for piemonkey January 27, 2025 12:21
@elpoelma elpoelma self-assigned this Jan 27, 2025
@elpoelma elpoelma force-pushed the internal/remove-ember-drag-drop branch from 9d9d7a0 to eded2aa Compare January 31, 2025 09:17
@elpoelma elpoelma force-pushed the internal/remove-ember-drag-drop branch from eded2aa to c3da45a Compare January 31, 2025 09:56
@elpoelma elpoelma merged commit 385467c into master Jan 31, 2025
3 checks passed
@elpoelma elpoelma deleted the internal/remove-ember-drag-drop branch January 31, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants