Fix issues related to decision article uri generation #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeforgit
approved these changes
Jan 31, 2025
elpoelma
force-pushed
the
bugfix/article-uri-generation
branch
from
c7e4f3d to
5487745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR ensures that both the 'Insert traffic measure' and 'Insert article block' insert decision articles with correctly defined URIs (not placeholder URIs)
connected issues and PRs:
lblod/ember-rdfa-editor-lblod-plugins#533
How to test/reproduce
Challenges/uncertainties
There's a typo in the config of roadsign-regulation plugin, will fix this in a PR on the editor-plugins...
Checks PR readiness