Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5228: fix selection issues when moving articles #823

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Jan 30, 2025

Overview

This PR includes a (dev-commit) editor update which fixes issues regarding the preservation of selections when having the defaultAttributeValueGeneration and/or listTrackingPlugin plugins enabled.
This fix also ensures that moving articles containg lists (e.g. mobility measures) can be done without issues.

connected issues and PRs:

lblod/ember-rdfa-editor#1247
GN-5228

How to test/reproduce

Check-out lblod/ember-rdfa-editor#1247

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Jan 30, 2025
@elpoelma elpoelma marked this pull request as ready for review January 31, 2025 09:14
@elpoelma elpoelma merged commit ac7b0fa into master Jan 31, 2025
3 checks passed
@elpoelma elpoelma deleted the GN-5228-moving-articles branch January 31, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant