Lmb 182 | can modify custom field #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVanHoof
changed the base branch from
karel/lmb-333-create-form-extensions
to
karel/lmb-809-library-of-fields
JonasVanHoof
force-pushed
the
lmb-182-can-modify-custom-field
branch
from
58d538b to
0e49d6b
Compare
Rahien
force-pushed
the
karel/lmb-809-library-of-fields
branch
from
ecfa31e to
1658d8c
Compare
JonasVanHoof
force-pushed
the
lmb-182-can-modify-custom-field
branch
from
221ac0d to
09bf43a
Compare
JonasVanHoof
commented
Jan 9, 2025
…to show this as a number for the DEMO 10/01/2025
…depending onj the action
…stom field button
JonasVanHoof
force-pushed
the
lmb-182-can-modify-custom-field
branch
from
27658c0 to
3f1b671
Compare
|
Added the order from Karels PR in here |
…-order allow changing field order
Base automatically changed from
karel/lmb-809-library-of-fields
to
karel/lmb-333-create-form-extensions
January 14, 2025 12:41
Rahien
requested changes
Jan 14, 2025
| @@ -27,6 +31,7 @@ export default class EditableFormComponent extends Component { | |||
| ); | |||
| this.currentForm = form; | |||
| this.loading = false; | |||
| this.showModal = false; | |||
There was a problem hiding this comment.
i don't think this is necessary if the tracked value is set to false?
There was a problem hiding this comment.
Indeed, the modal is not closed when not doing this
Rahien
requested changes
Jan 15, 2025
Rahien
approved these changes
Jan 15, 2025
JonasVanHoof
merged commit 14ba654
into
karel/lmb-333-create-form-extensions
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want the user to edit the custom form field. Adding an edit icon that opens a modal with the editable fields.
How to test
Edit a custom field in the mandataris extra info card
Links to other PR's
Attachments