Lmb 1226 | can mark custom field required #458
Conversation
JonasVanHoof
changed the base branch from
master
to
lmb-182-can-modify-custom-field
JonasVanHoof
force-pushed
the
lmb-181-add-more-displaytypes
branch
from
5806cfb to
092a696
Compare
JonasVanHoof
force-pushed
the
lmb-181-add-more-displaytypes
branch
from
0b99724 to
53ae14b
Compare
JonasVanHoof
changed the title
| get canShowRequiredToggle() { | ||
| return this.displayType.uri !== ADRES_CUSTOM_DISPLAY_TYPE; | ||
| } |
There was a problem hiding this comment.
Important the adress component cannot handle the validations as other rdf inputs do
There was a problem hiding this comment.
should we not just make it handle that then? Its value is just a uri so i think the default checks should work for it?
There was a problem hiding this comment.
It works with an adres as displaytype but I can't seem to make it work for the library entry "Verblijfplaats", the path of the validation and the field are the same. I removed the restriction of the required toggle not showing, the remark will than be that the verblijfplaats field will CAN be filled in as empty.
Rahien
force-pushed
the
karel/lmb-333-create-form-extensions
branch
from
14ba654 to
439b213
Compare
JonasVanHoof
force-pushed
the
lmb-181-add-more-displaytypes
branch
2 times, most recently
from
599008b to
55e0bc7
Compare
There was a problem hiding this comment.
apart from this, when changing field type a couple of times, the "dit veld is verplicht" error message is duplicated and see if you can fix the behavior when something that is not a number or date is filled in but the type is changed to number or date. Nothing is shown and the form can be saved because there is a value. Maybe it should clear that value in that case?
| get canShowRequiredToggle() { | ||
| return this.displayType.uri !== ADRES_CUSTOM_DISPLAY_TYPE; | ||
| } |
There was a problem hiding this comment.
should we not just make it handle that then? Its value is just a uri so i think the default checks should work for it?
JonasVanHoof
force-pushed
the
lmb-181-add-more-displaytypes
branch
from
6043bb7 to
95c46fb
Compare
JonasVanHoof
merged commit 01f4d46
into
karel/lmb-333-create-form-extensions
Description
You should be able to add a telephone number field that has phone validation + make it possible to mark a field as required
How to test
Add these fields to a form and see if the validations are correct.
Links to other PR's
Attachments