Herald.go #47
Herald.go #47
Conversation
jeffreypicard
commented
Aug 4, 2022
jeffreypicard
commented
- Changes to the codebase for the second repo rename.
- Updates to the ci/cd scripts and docker files for static builds
protobuf/go/result.pb.go
Outdated
| 0x63, 0x68, 0x61, 0x6e, 0x6e, 0x65, 0x6c, 0x42, 0x26, 0x5a, 0x24, 0x67, 0x69, 0x74, 0x68, 0x75, | ||
| 0x62, 0x2e, 0x63, 0x6f, 0x6d, 0x2f, 0x6c, 0x62, 0x72, 0x79, 0x69, 0x6f, 0x2f, 0x68, 0x75, 0x62, | ||
| 0x2f, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2f, 0x67, 0x6f, 0x2f, 0x70, 0x62, 0x62, | ||
| 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, | ||
| 0x63, 0x68, 0x61, 0x6e, 0x6e, 0x65, 0x6c, 0x42, 0x29, 0x5a, 0x27, 0x67, 0x69, 0x74, 0x68, 0x75, | ||
| 0x62, 0x2e, 0x63, 0x6f, 0x6d, 0x2f, 0x6c, 0x62, 0x72, 0x79, 0x69, 0x6f, 0x2f, 0x68, 0x65, 0x72, | ||
| 0x61, 0x6c, 0x64, 0x2f, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2f, 0x67, 0x6f, 0x2f, | ||
| 0x70, 0x62, 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, |
There was a problem hiding this comment.
Is this changing because build.sh is downloading a different version of protoc-gen-go-grpc?
Stuff in lbryio/types has not changed much recently.
There was a problem hiding this comment.
Yes, I believe so. Perhaps also due to the move to go 1.18. Let's talk about which direction we want to sync these up in in the call.
We've already renamed it twice haha, I think this time was being X.go is the standard naming convention, so we'll just have to figure out how to fix the binary at this point I think. |
|
Looks good. Only open question is why the .pb.go files changed. |
So I think it's a moot point now actually, he package name in the .proto had to change anyways actually so it had to change the generated files. I'm going to merge this, pull in your change from the other one, and then cut a new version. |
