Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catchup to python-herald schema. Plus lots of refactoring. #49

Merged
merged 18 commits into from
Aug 16, 2022

Conversation

moodyjon
Copy link
Contributor

@moodyjon moodyjon commented Aug 10, 2022

Fixes #46

Still debugging a test. Need to add test data for new tables.

@moodyjon moodyjon marked this pull request as draft August 10, 2022 17:30
@moodyjon
Copy link
Contributor Author

I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS.

@jeffreypicard
Copy link
Collaborator

I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS.

Do you have access to a linux vps or something that you can commit those on?

@jeffreypicard
Copy link
Collaborator

Also, I don't think we want to commit that .DS_Store file.

@moodyjon
Copy link
Contributor Author

I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS.

Do you have access to a linux vps or something that you can commit those on?

I had moved the working dir to a special case-sensitive volume a while back once I discovered the issue.
What remained to be done was changing the .git/config to contain core.ignorecase = false
Test data is there now.

@moodyjon moodyjon marked this pull request as ready for review August 11, 2022 18:11
@moodyjon moodyjon requested a review from jeffreypicard August 12, 2022 00:33
@lbry-bot lbry-bot assigned jeffreypicard and unassigned moodyjon Aug 12, 2022
@jeffreypicard jeffreypicard merged commit 071aa2a into lbryio:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring herald/db/prefixes.go up to date with new tables
2 participants