-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catchup to python-herald schema. Plus lots of refactoring. #49
Conversation
I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS. |
Do you have access to a linux vps or something that you can commit those on? |
Also, I don't think we want to commit that .DS_Store file. |
by a prior crash. Also correct error logging.
HistFlushCount, CompFlushCount, CompCursor. Python-herald doesn't do it, and it presents one more irregular case for (un)marshalling fields.
use of "restruct" generic packing/unpacking.
Dispatch normal pack/unpack through tableRegistry[] map instead of switch.
Populate PrefixRowKV.RawKey,RawValue when appropriate.
as I can't find the right annotation to get it marshalled/unmarshalled.
in UnpackKey/UnpackValue for new types.
f36424f
to
99a93e5
Compare
Add Fuzz tests for TouchedHashXKey, TouchedHashXValue with happy path test data (only).
I had moved the working dir to a special case-sensitive volume a while back once I discovered the issue. |
Other minor fixes, comments.
they are registered in prefixRegistry.
Fixes #46
Still debugging a test. Need to add test data for new tables.