Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RepostedCount, EffectiveAmount prefix rows #51

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

moodyjon
Copy link
Contributor

@moodyjon moodyjon commented Aug 19, 2022

Work-in-progress... Fixes #46

Currently looking into how the tables are used to service requests, and finding places that need an update to use the new tables.

[edit] Completed changes to db_get.go, db_test.go accounting for new tables.

@moodyjon moodyjon marked this pull request as draft August 19, 2022 14:36
Comment on lines +2 to +3
S,532556ed1cab9d17f2a9392030a9ad7f5d138f11bd01000a6b67006286030000,0000007615cbad28
S,532556ed1cab9d17f2a9392030a9ad7f5d138f11bd01000a706a0063105c0000,000000000bebc200
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed 2 of these rows to be ActivateClaimTXOType (1) instead of ActivatedSupportTXOType (2)..

@lbry-bot lbry-bot assigned moodyjon and unassigned moodyjon Aug 23, 2022
@moodyjon moodyjon requested a review from jeffreypicard August 23, 2022 16:39
@lbry-bot lbry-bot assigned jeffreypicard and unassigned moodyjon Aug 23, 2022
@moodyjon moodyjon marked this pull request as ready for review August 23, 2022 16:39
Copy link
Collaborator

@jeffreypicard jeffreypicard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@lbry-bot lbry-bot assigned moodyjon and unassigned jeffreypicard Aug 26, 2022
@jeffreypicard jeffreypicard merged commit 9d9c73f into lbryio:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring herald/db/prefixes.go up to date with new tables
2 participants