Add element type param T to SlicedBacked[T]. Require T satisfy #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constraints.Ordered to make BisectRight() statically type-safe.
|
We should figure out why the unit tests don't run automatically for PRs from other repos, or if you have the permissions you could just make branches in our repo and I think then they'll trigger properly. |
|
Otherwise this looks good, I like taking advantage of these features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add element type param T to SlicedBacked[T]. Require T satisfy constraints.Ordered to make BisectRight() statically type-safe.
Found this working on the RPCs. I want to use
db.TxCountsto lookup the height of a TXO. (And I don't have two txcounts, just one). While changing the argument/return signature, I added a type param.