setup.py: use plyvel==1.2.0
instead of 1.0.5
#3357
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in
INSTALL.md
, setting up the virtual environment and runningmake
.The process errors in the compilation of
plyvel
.To avoid this error, we can set
plyvel==1.2.0
orplyvel==1.3.0
insetup.py
. Then the installation completes fine.I don't know if there is a particular reason for using
plyvel==1.0.5
(July 17, 2018), as it is currently. This version compiles fine with Python 3.7 and 3.8, but only 3.7 truly works correctly (see #2769, #2145).I tried
plyvel==1.2.0
(January 22, 2020) because it's the version available in Ubuntu 20.04, andplyvel==1.3.0
(October 10, 2020) because it's the latest stable version available in Arch.If this is merged, then maybe we don't need to install
libleveldb-dev
, as proposed in #3349.This fix is also included in #3205, so if #3205 is merged, this pull request is not needed. Otherwise this can be merged already.