Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test of system clock using default timezone #32

Merged
merged 1 commit into from
Apr 26, 2020
Merged

fix test of system clock using default timezone #32

merged 1 commit into from
Apr 26, 2020

Conversation

slepic
Copy link
Contributor

@slepic slepic commented Apr 24, 2020

hi, me again:)

I just noticed that the test for SystemClock is written so that it relies that the machine running the test has UTC as default. Probably would be better to use the actual system default...

Copy link
Owner

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Thanks for your contribution 👍

@lcobucci lcobucci self-assigned this Apr 26, 2020
@lcobucci lcobucci added this to the 1.4.0 milestone Apr 26, 2020
@lcobucci lcobucci merged commit 412a08d into lcobucci:master Apr 26, 2020
@slepic slepic deleted the system-clock-test-use-default-timezone branch August 27, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants