Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitattributes #5

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Add .gitattributes #5

merged 1 commit into from
Mar 8, 2018

Conversation

1ma
Copy link
Contributor

@1ma 1ma commented Mar 8, 2018

@lcobucci lcobucci self-assigned this Mar 8, 2018
@lcobucci lcobucci added this to the 1.2.0 milestone Mar 8, 2018
lcobucci
lcobucci approved these changes Mar 8, 2018
View reviewed changes
Copy link
Owner

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome, thanks!

lcobucci
lcobucci requested changes Mar 8, 2018
View reviewed changes
Copy link
Owner

@lcobucci lcobucci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing (I was too eager to get it merged)

.gitattributes Outdated
@@ -0,0 +1,7 @@
/tests export-ignore
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this is not really correct... It is test instead (unless you would like to a commit to move things around)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, sorry 😅

@1ma
Copy link
Contributor Author

1ma commented Mar 8, 2018 •
edited
Loading

Fixed. I'd rather not move the whole directory and splash my nickname on everything.

@lcobucci lcobucci merged commit 8db6caa into lcobucci:master Mar 8, 2018
@lcobucci
Copy link
Owner

lcobucci commented Mar 8, 2018

@1ma 🚢 I'll be releasing it ASAP, thanks for your contribution!

Regarding the "splash my nickname on everything": I'm more than happy to have more nicknames everywhere. So if you do think that tests is a better folder name and are willing to send a PR to change it, please do it!

@1ma 1ma deleted the add-gitattributes branch March 8, 2018 19:34
@1ma
Copy link
Contributor Author

1ma commented Mar 8, 2018

Ah, it's not a humbleness thingy, just a practical matter. If my name is splashed over every single line of code in the test directory git blame would lose a bit of its usefulness (granted that that project is very small and has just a handful of commits).

At any rate, I don't think tests is any better than test, I just happened to adapt the file from one of my packages and that mistake slipped by.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcobucci lcobucci lcobucci approved these changes

Assignees

@lcobucci lcobucci

Labels
Improvement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1ma @lcobucci