Merge pull request #6 from lcobucci/update-standard

Upgrade to Doctrine CS v7.0
lcobucci · Feb 25, 2020 · f6cfe0d · f6cfe0d
2 parents 55aa7c5 + eeac789
commit f6cfe0d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -3,8 +3,7 @@ sudo: false
 language: php
 
 php:
-  - 7.3
-  - 7.4snapshot
+  - 7.4
   - nightly
 
 cache:
@@ -22,5 +21,4 @@ script:
 
 jobs:
   allow_failures:
-    - php: 7.4snapshot
     - php: nightly
diff --git a/composer.json b/composer.json
@@ -10,8 +10,8 @@
         }
     ],
     "require": {
-        "php": "^7.3 || ^8.0",
-        "doctrine/coding-standard": "^6.0"
+        "php": "^7.4 || ^8.0",
+        "doctrine/coding-standard": "^7.0"
     },
     "require-dev": {
         "roave/security-advisories": "dev-master"

diff --git a/tests/ExampleClassWithNoViolation.php b/tests/ExampleClassWithNoViolation.php
@@ -3,6 +3,9 @@
 
 namespace Lcobucci;
 
+use function sprintf;
+use const PHP_EOL;
+
 /**
  * @runTestsInSeparateProcesses
  *
@@ -12,10 +15,7 @@
  */
 final class ExampleClassWithNoViolation
 {
-    /**
-     * @var int
-     */
-    private $test = 0;
+    private int $test = 0;
 
     /**
      * @internal
@@ -59,6 +59,7 @@ final class ExampleClassWithNoViolation
      */
     public function aMethodWithAllUsefulAnnotations(): void
     {
+        echo PHP_EOL;
         echo $this->test;
     }
 
@@ -83,6 +84,7 @@ public function aMethodWithAllUsefulAnnotations(): void
      */
     public function sampleForPHPUnitTests(): void
     {
+        echo sprintf('Testing %d', 1);
         echo $this->test;
     }
 }