Make formatters rely on PSR-7 responses

Providing more flexibility to users and simplifying the API.
lcobucci · Jul 2, 2020 · 7440587 · 7440587
1 parent 645adf1
commit 7440587
Show file tree

Hide file tree

Showing 19 changed files with 178 additions and 82 deletions.
diff --git a/README.md b/README.md
@@ -167,15 +167,17 @@ declare(strict_types=1);
 namespace Me\MyApp;
 
 use Lcobucci\ContentNegotiation\Formatter;
+use Lcobucci\ContentNegotiation\UnformattedResponse;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\StreamFactoryInterface;
 
 final class MyFancyFormatter implements Formatter
 {
-    public function format($content, array $attributes = []): string
+    public function format(UnformattedResponse $response, StreamFactoryInterface $streamFactory): ResponseInterface
     {
-        // Performs all the magic with $content and creates $result with a
-        // `string` containing the formatted data.
+        $content = ''; // Do some fancy formatting of $response->getUnformattedContent() and put into $content
 
-        return $result;
+        return $response->withBody($streamFactory->createStream($content));
     }
 }
 ```

diff --git a/src/ContentTypeMiddleware.php b/src/ContentTypeMiddleware.php
@@ -3,7 +3,7 @@
 
 namespace Lcobucci\ContentNegotiation;
 
-use Fig\Http\Message\StatusCodeInterface;
+use Lcobucci\ContentNegotiation\Formatter\NotAcceptable;
 use Middlewares\ContentType;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
@@ -66,9 +66,9 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
         }
 
         $contentType = $this->extractContentType($response->getHeaderLine('Content-Type'));
-        $formatter   = $this->formatters[$contentType] ?? null;
+        $formatter   = $this->formatters[$contentType] ?? new NotAcceptable();
 
-        return $this->formatResponse($response, $formatter);
+        return $formatter->format($response, $this->streamFactory);
     }
 
     private function extractContentType(string $contentType): string
@@ -81,21 +81,4 @@ private function extractContentType(string $contentType): string
 
         return substr($contentType, 0, $charsetSeparatorPosition);
     }
-
-    /**
-     * @throws ContentCouldNotBeFormatted
-     */
-    private function formatResponse(UnformattedResponse $response, ?Formatter $formatter): ResponseInterface
-    {
-        if ($formatter === null) {
-            return $response->withBody($this->streamFactory->createStream())
-                            ->withStatus(StatusCodeInterface::STATUS_NOT_ACCEPTABLE);
-        }
-
-        return $response->withBody(
-            $this->streamFactory->createStream(
-                $formatter->format($response->getUnformattedContent(), $response->getAttributes())
-            )
-        );
-    }
 }
diff --git a/src/Formatter.php b/src/Formatter.php
@@ -3,13 +3,13 @@
 
 namespace Lcobucci\ContentNegotiation;
 
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\StreamFactoryInterface;
+
 interface Formatter
 {
     /**
-     * @param mixed   $content
-     * @param mixed[] $attributes
-     *
      * @throws ContentCouldNotBeFormatted
      */
-    public function format($content, array $attributes = []): string;
+    public function format(UnformattedResponse $response, StreamFactoryInterface $streamFactory): ResponseInterface;
 }
diff --git a/src/Formatter/ContentOnly.php b/src/Formatter/ContentOnly.php
@@ -0,0 +1,29 @@
+<?php
+declare(strict_types=1);
+
+namespace Lcobucci\ContentNegotiation\Formatter;
+
+use Lcobucci\ContentNegotiation\ContentCouldNotBeFormatted;
+use Lcobucci\ContentNegotiation\Formatter;
+use Lcobucci\ContentNegotiation\UnformattedResponse;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\StreamFactoryInterface;
+
+abstract class ContentOnly implements Formatter
+{
+    /** @throws ContentCouldNotBeFormatted */
+    public function format(UnformattedResponse $response, StreamFactoryInterface $streamFactory): ResponseInterface
+    {
+        return $response->withBody(
+            $streamFactory->createStream(
+                $this->formatContent($response->getUnformattedContent(), $response->getAttributes())
+            )
+        );
+    }
+
+    /**
+     * @param mixed   $content
+     * @param mixed[] $attributes
+     */
+    abstract public function formatContent($content, array $attributes = []): string;
+}
diff --git a/src/Formatter/JmsSerializer.php b/src/Formatter/JmsSerializer.php
@@ -5,11 +5,10 @@
 
 use JMS\Serializer\SerializerInterface;
 use Lcobucci\ContentNegotiation\ContentCouldNotBeFormatted;
-use Lcobucci\ContentNegotiation\Formatter;
 use Throwable;
 use function sprintf;
 
-final class JmsSerializer implements Formatter
+final class JmsSerializer extends ContentOnly
 {
     private SerializerInterface $serializer;
     private string $format;
@@ -23,7 +22,7 @@ public function __construct(SerializerInterface $serializer, string $format)
     /**
      * {@inheritdoc}
      */
-    public function format($content, array $attributes = []): string
+    public function formatContent($content, array $attributes = []): string
     {
         try {
             return $this->serializer->serialize($content, $this->format);

diff --git a/src/Formatter/Json.php b/src/Formatter/Json.php
@@ -4,7 +4,6 @@
 namespace Lcobucci\ContentNegotiation\Formatter;
 
 use Lcobucci\ContentNegotiation\ContentCouldNotBeFormatted;
-use Lcobucci\ContentNegotiation\Formatter;
 use Throwable;
 use function json_encode;
 use function sprintf;
@@ -15,7 +14,7 @@
 use const JSON_THROW_ON_ERROR;
 use const JSON_UNESCAPED_SLASHES;
 
-final class Json implements Formatter
+final class Json extends ContentOnly
 {
     private const DEFAULT_FLAGS = JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_AMP | JSON_HEX_QUOT | JSON_UNESCAPED_SLASHES;
 
@@ -29,7 +28,7 @@ public function __construct(int $flags = self::DEFAULT_FLAGS)
     /**
      * {@inheritdoc}
      */
-    public function format($content, array $attributes = []): string
+    public function formatContent($content, array $attributes = []): string
     {
         try {
             return json_encode($content, $this->flags | JSON_THROW_ON_ERROR);

diff --git a/src/Formatter/NotAcceptable.php b/src/Formatter/NotAcceptable.php
@@ -0,0 +1,19 @@
+<?php
+declare(strict_types=1);
+
+namespace Lcobucci\ContentNegotiation\Formatter;
+
+use Fig\Http\Message\StatusCodeInterface;
+use Lcobucci\ContentNegotiation\Formatter;
+use Lcobucci\ContentNegotiation\UnformattedResponse;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\StreamFactoryInterface;
+
+class NotAcceptable implements Formatter
+{
+    public function format(UnformattedResponse $response, StreamFactoryInterface $streamFactory): ResponseInterface
+    {
+        return $response->withBody($streamFactory->createStream())
+                        ->withStatus(StatusCodeInterface::STATUS_NOT_ACCEPTABLE);
+    }
+}
diff --git a/src/Formatter/Plates.php b/src/Formatter/Plates.php
@@ -4,11 +4,10 @@
 namespace Lcobucci\ContentNegotiation\Formatter;
 
 use Lcobucci\ContentNegotiation\ContentCouldNotBeFormatted;
-use Lcobucci\ContentNegotiation\Formatter;
 use League\Plates\Engine;
 use Throwable;
 
-final class Plates implements Formatter
+final class Plates extends ContentOnly
 {
     private const DEFAULT_ATTRIBUTE = 'template';
 
@@ -24,7 +23,7 @@ public function __construct(Engine $engine, string $attributeName = self::DEFAUL
     /**
      * {@inheritdoc}
      */
-    public function format($content, array $attributes = []): string
+    public function formatContent($content, array $attributes = []): string
     {
         try {
             return $this->render($content, $attributes);

diff --git a/src/Formatter/StringCast.php b/src/Formatter/StringCast.php
@@ -4,16 +4,15 @@
 namespace Lcobucci\ContentNegotiation\Formatter;
 
 use Lcobucci\ContentNegotiation\ContentCouldNotBeFormatted;
-use Lcobucci\ContentNegotiation\Formatter;
 use function is_object;
 use function method_exists;
 
-final class StringCast implements Formatter
+final class StringCast extends ContentOnly
 {
     /**
      * {@inheritdoc}
      */
-    public function format($content, array $attributes = []): string
+    public function formatContent($content, array $attributes = []): string
     {
         if (is_object($content) && ! method_exists($content, '__toString')) {
             throw new ContentCouldNotBeFormatted('Given data could not be cast to string');

diff --git a/src/Formatter/Twig.php b/src/Formatter/Twig.php
@@ -4,11 +4,10 @@
 namespace Lcobucci\ContentNegotiation\Formatter;
 
 use Lcobucci\ContentNegotiation\ContentCouldNotBeFormatted;
-use Lcobucci\ContentNegotiation\Formatter;
 use Throwable;
 use Twig\Environment;
 
-final class Twig implements Formatter
+final class Twig extends ContentOnly
 {
     private const DEFAULT_ATTRIBUTE = 'template';
 
@@ -26,7 +25,7 @@ public function __construct(
     /**
      * {@inheritdoc}
      */
-    public function format($content, array $attributes = []): string
+    public function formatContent($content, array $attributes = []): string
     {
         try {
             return $this->render($content, $attributes);

diff --git a/tests/ContentTypeMiddlewareTest.php b/tests/ContentTypeMiddlewareTest.php
@@ -46,6 +46,7 @@ final class ContentTypeMiddlewareTest extends TestCase
      * @covers ::process()
      *
      * @uses \Lcobucci\ContentNegotiation\Formatter\Json
+     * @uses \Lcobucci\ContentNegotiation\Formatter\ContentOnly
      */
     public function processShouldReturnFormattedResponseDirectly(): void
     {
@@ -64,10 +65,10 @@ public function processShouldReturnFormattedResponseDirectly(): void
      * @covers ::fromRecommendedSettings()
      * @covers ::process()
      * @covers ::extractContentType()
-     * @covers ::formatResponse()
      *
      * @uses \Lcobucci\ContentNegotiation\UnformattedResponse
      * @uses \Lcobucci\ContentNegotiation\Formatter\Json
+     * @uses \Lcobucci\ContentNegotiation\Formatter\NotAcceptable
      */
     public function processShouldReturnAResponseWithErrorWhenFormatterWasNotFound(): void
     {
@@ -90,9 +91,9 @@ public function processShouldReturnAResponseWithErrorWhenFormatterWasNotFound():
      * @covers ::fromRecommendedSettings()
      * @covers ::process()
      * @covers ::extractContentType()
-     * @covers ::formatResponse()
      *
      * @uses \Lcobucci\ContentNegotiation\UnformattedResponse
+     * @uses \Lcobucci\ContentNegotiation\Formatter\ContentOnly
      * @uses \Lcobucci\ContentNegotiation\Formatter\Json
      */
     public function processShouldReturnAResponseWithFormattedContent(): void
@@ -117,9 +118,9 @@ public function processShouldReturnAResponseWithFormattedContent(): void
      * @covers ::fromRecommendedSettings()
      * @covers ::process()
      * @covers ::extractContentType()
-     * @covers ::formatResponse()
      *
      * @uses \Lcobucci\ContentNegotiation\UnformattedResponse
+     * @uses \Lcobucci\ContentNegotiation\Formatter\ContentOnly
      * @uses \Lcobucci\ContentNegotiation\Formatter\Json
      */
     public function processShouldPassAttributesToTheFormatterProperly(): void
@@ -148,9 +149,9 @@ public function processShouldPassAttributesToTheFormatterProperly(): void
      * @covers ::fromRecommendedSettings()
      * @covers ::process()
      * @covers ::extractContentType()
-     * @covers ::formatResponse()
      *
      * @uses \Lcobucci\ContentNegotiation\UnformattedResponse
+     * @uses \Lcobucci\ContentNegotiation\Formatter\ContentOnly
      * @uses \Lcobucci\ContentNegotiation\Formatter\Json
      */
     public function processShouldReturnAResponseWithFormattedContentEvenWithoutForcingTheCharset(): void

diff --git a/tests/Formatter/ContentOnlyTest.php b/tests/Formatter/ContentOnlyTest.php
@@ -0,0 +1,33 @@
+<?php
+declare(strict_types=1);
+
+namespace Lcobucci\ContentNegotiation\Tests\Formatter;
+
+use Laminas\Diactoros\Response;
+use Laminas\Diactoros\StreamFactory;
+use Lcobucci\ContentNegotiation\Formatter\ContentOnly;
+use Lcobucci\ContentNegotiation\UnformattedResponse;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversDefaultClass \Lcobucci\ContentNegotiation\Formatter\ContentOnly
+ */
+final class ContentOnlyTest extends TestCase
+{
+    /**
+     * @test
+     *
+     * @covers ::format
+     *
+     * @uses \Lcobucci\ContentNegotiation\UnformattedResponse
+     */
+    public function formatShouldDelegateTheFormattingToTheConcreteClasses(): void
+    {
+        $formatter = $this->getMockForAbstractClass(ContentOnly::class);
+        $formatter->method('formatContent')->willReturn('A fancy result');
+
+        $response = $formatter->format(new UnformattedResponse(new Response(), 'testing'), new StreamFactory());
+
+        self::assertSame('A fancy result', $response->getBody()->getContents());
+    }
+}
diff --git a/tests/Formatter/JmsSerializerTest.php b/tests/Formatter/JmsSerializerTest.php
@@ -32,7 +32,7 @@ public function createSerializer(): void
      * @test
      *
      * @covers ::__construct()
-     * @covers ::format()
+     * @covers ::formatContent()
      */
     public function formatShouldSimplyForwardCallToSerializer(): void
     {
@@ -45,14 +45,14 @@ public function formatShouldSimplyForwardCallToSerializer(): void
 
         $formatter = new JmsSerializer($this->serializer, 'json');
 
-        self::assertSame('{"a":"test"}', $formatter->format($content));
+        self::assertSame('{"a":"test"}', $formatter->formatContent($content));
     }
 
     /**
      * @test
      *
      * @covers ::__construct()
-     * @covers ::format()
+     * @covers ::formatContent()
      */
     public function formatShouldConvertAnyRaisedException(): void
     {
@@ -62,6 +62,6 @@ public function formatShouldConvertAnyRaisedException(): void
                          ->willThrowException(new RuntimeException());
 
         $formatter = new JmsSerializer($this->serializer, 'json');
-        $formatter->format(['a' => 'test']);
+        $formatter->formatContent(['a' => 'test']);
     }
 }