Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.3 #645

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Support PHP 8.3 #645

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f082785
Add PHP 8.3 support
lcobucci Nov 22, 2023
09c9037
Upgrade lcobucci/coding-standard to v11
lcobucci Nov 22, 2023
e19ec64
Allow the usage of psr/http-message v2.0
lcobucci Nov 22, 2023
76ca6f9
Upgrade PHPUnit to v10.4
lcobucci Nov 22, 2023
dc7fe92
Update Symfony dependencies
lcobucci Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"ext-json": "*",
"fig/http-message-util": "^1.1.5",
"psr/http-factory": "^1.0.2",
"psr/http-message": "^1.1.0",
"psr/http-message": "^1.1 || ^2.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏽 wondering if this is a WIP for the 3.3.x version, but it looks like Lcobucci\ContentNegotiation\UnformattedResponse is not compatible with the contracts of Psr\Http\Message\ResponseInterface psr/http-message:2.0.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!
Our pipeline didn't detect that due to dependency constraints 😥

https://packagist.org/packages/middlewares/negotiation needs a release to be compatible with v4 of https://packagist.org/packages/middlewares/utils.

@oscarotero is that on your plans?

"psr/http-server-middleware": "^1.0.2"
},
"require-dev": {
Expand Down
2 changes: 1 addition & 1 deletion composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.