Provide initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the application mode, we may need extra debugging information in the response body - which can definitely help us to solve the issue more easily. This provides the extension point and two default implementations: - `NoDebugInfo`: aimed for production mode, doesn't add any debug information - `NoTrace`: aimed for development mode, extracts all exception data but the trace - also for previous exceptions.
One of the main differentiators of this package is the usage of marker interfaces to perform the translation from error/exception to HTTP responses. This provides the extension point for that operation and a default strategy using a translation map (class/interface -> HTTP status code).
This proposes the split between logging and converting errors into response. The idea is to always add a debug message with the error that happened, which is handy for both production and development. In combination with an access log middleware we can log errors or warnings, depending on the final response status code. For production, we assume that a fingers crossed handler is used so that only errors are sent to log - with enough information. More info: - https://github.com/middlewares/access-log/blob/master/src/AccessLog.php - https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/FingersCrossedHandler.php
Leaving the formatting to another middleware in the pipeline. More info: - https://github.com/lcobucci/content-negotiation-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.