Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React's Context API #55

Open
leandrohsilveira opened this issue Jul 23, 2018 · 1 comment
Open

Use React's Context API #55

leandrohsilveira opened this issue Jul 23, 2018 · 1 comment
Assignees
@leandrohsilveira
Labels
blocked enhancement
Milestone
v1.5.0

Comments

@leandrohsilveira
Copy link
Owner

Is your feature request related to a problem? Please describe.
The React Form CTRL event bus increases a lot the final bundle size.

Describe the solution you'd like
The lib should use Context API instead to improve performance and bundle size.
@leandrohsilveira leandrohsilveira self-assigned this Jul 23, 2018
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 remove form provider effects
35a603a
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 React version upgraded to 16.3.x
2157798
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 Removed "formRef" from payload
2997a53
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 Remove "formRef" from action creators
395a6cc
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 using form context to FormProvider
6d4bf61
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 using FormConsumer on Form and FormControl components
027eeff
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 lint
6a6dc85
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 lint
935d7bc
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 using FormConsumer on Field component
1ce97bd
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 upgrading ReactDOM and Enzyme dependencies
e4c1b2c
leandrohsilveira added a commit that referenced this issue Jul 31, 2018
@leandrohsilveira
#55 fixing bugs
e52ed80
@leandrohsilveira
Copy link
Owner Author

leandrohsilveira commented Aug 2, 2018 •
edited
Loading

Issue blocked since i'm unable to test with new context api due to an Enzyme issue: enzymejs/enzyme#1509

leandrohsilveira added a commit that referenced this issue Aug 2, 2018
@leandrohsilveira
#55 fixed some undefined ref bugs
d8c292f
@leandrohsilveira leandrohsilveira added this to the v1.5.0 milestone Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrohsilveira leandrohsilveira

Labels
blocked enhancement
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
1 participant
@leandrohsilveira