Change Projects() to return pointers

leanovate · Apr 3, 2019 · 1f35cad · 1f35cad
1 parent d8cd0df
commit 1f35cad
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/mite/api.go b/mite/api.go
@@ -11,7 +11,7 @@ const userAgent = "mite-go/0.1 (+github.com/leanovate/mite-go)"
 const layout = "2006-01-02"
 
 type MiteApi interface {
-	Projects() ([]Project, error)
+	Projects() ([]*Project, error)
 	Services() ([]Service, error)
 	TimeEntries(params *TimeEntryParameters) ([]TimeEntry, error)
 	TimeEntry(id string) (*TimeEntry, error)

diff --git a/mite/project.go b/mite/project.go
@@ -10,33 +10,33 @@ type Project struct {
 	Note string
 }
 
-func (a *miteApi) Projects() ([]Project, error) {
-	prs := []ProjectResponse{}
-	err := a.get("projects.json", &prs)
-	if err != nil {
-		return nil, err
-	}
-
-	projects := []Project{}
-	for _, pr := range prs {
-		projects = append(projects, pr.ToProject())
-	}
-
-	return projects, nil
-}
-
-type ProjectResponse struct {
+type projectResponse struct {
 	Project struct {
 		Id   int    `json:"id"`
 		Name string `json:"name"`
 		Note string `json:"note"`
 	} `json:"project"`
 }
 
-func (r ProjectResponse) ToProject() Project {
-	return Project{
+func (r *projectResponse) ToProject() *Project {
+	return &Project{
 		Id:   fmt.Sprintf("%d", r.Project.Id),
 		Name: r.Project.Name,
 		Note: r.Project.Note,
 	}
 }
+
+func (a *miteApi) Projects() ([]*Project, error) {
+	prs := []projectResponse{}
+	err := a.get("projects.json", &prs)
+	if err != nil {
+		return nil, err
+	}
+
+	projects := []*Project{}
+	for _, pr := range prs {
+		projects = append(projects, pr.ToProject())
+	}
+
+	return projects, nil
+}