Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: more unused variables #18889

Closed
wants to merge 2 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Nov 11, 2024

Copy link

github-actions bot commented Nov 11, 2024

PR summary 60e2050f79

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just two very minor comments.
maintainer merge

Mathlib/Analysis/Calculus/Deriv/Add.lean Outdated Show resolved Hide resolved
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@sgouezel
Copy link
Contributor

bors d+
Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 12, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@adomani
Copy link
Collaborator Author

adomani commented Nov 12, 2024

Thank you for your comments!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 12, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: more unused variables [Merged by Bors] - chore: more unused variables Nov 12, 2024
@mathlib-bors mathlib-bors bot closed this Nov 12, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/more_removed_variables branch November 12, 2024 14:02
Jun2M pushed a commit that referenced this pull request Nov 17, 2024
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants